colexec: call SetLength on output batches for window functions #66398
+23
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
yuzefovich
approved these changes
Jun 12, 2021
There was a problem hiding this comment.
nit: no need for a release note since there hasn't been a stable release with this bug.
Reviewed 2 of 2 files at r1.
Reviewable status:complete! 1 of 0 LGTMs obtained (waiting on @DrewKimball)
|
TFTR! |
Previously, `bufferedWindowOp` would return batches immediately after their output columns were entirely filled. However, this caused the non-decreasing invariant to be violated for bytes output columns when there were trailing nulls. This patch modifies `bufferedWindowOp` to call `SetLength` on each batch before it is returned. This ensures that the bytes invariant is maintained when there are trailing nulls. See cockroachdb#64793 Release note: None
|
bors r+ |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously,
bufferedWindowOpwould return batches immediatelyafter their output columns were entirely filled. However, this caused
the non-decreasing invariant to be violated for bytes output columns
when there were trailing nulls.
This patch modifies
bufferedWindowOpto callSetLengthon eachbatch before it is returned. This ensures that the bytes invariant is
maintained when there are trailing nulls.
See #64793
Release note: None