colexecbase: add casts from decimals to ints and floats #66379
Conversation
|
This change is |
yuzefovich
force-pushed
the
vec-casts
branch
2 times, most recently
from
b5e7b19 to
c9bc7c9
Compare
There was a problem hiding this comment.
Reviewed 1 of 5 files at r1.
Reviewable status:complete! 1 of 0 LGTMs obtained (waiting on @michae2 and @yuzefovich)
pkg/sql/colexec/execgen/cmd/execgen/overloads_cast.go, line 176 at r1 (raw file):
// // NOTE: when updating the code below, make sure to update tree/casts.go // as well.
Blah, I wish we could find a way to avoid this duplication...
There was a problem hiding this comment.
Reviewable status:
This commit adds vectorized casts from decimals to ints (of all widths) and floats. Release note: None
There was a problem hiding this comment.
I had to adjust recently merged logic test.
TFTR!
bors r+
Reviewable status:
pkg/sql/colexec/execgen/cmd/execgen/overloads_cast.go, line 176 at r1 (raw file):
Previously, jordanlewis (Jordan Lewis) wrote…
Blah, I wish we could find a way to avoid this duplication...
I think we'll have to generate tree/casts.go (or relevant parts of it) from a template too :)
|
Build succeeded: |
This commit adds vectorized casts from decimals to ints (of all widths)
and floats.
Addresses: #48135.
Release note: None