sqlproxy: fix some small issues and tidy up files and comments #66369
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
darinpp
reviewed
Jun 11, 2021
darinpp
approved these changes
Jun 11, 2021
darinpp
reviewed
Jun 11, 2021
andy-kimball
force-pushed
the
sqlproxy
branch
2 times, most recently
from
e3d33d4 to
e022795
Compare
Do a bit of reorganization/tidying of files: 1. Remove mock files, which are never used. 2. Move tests into package directory they are testing. Avoid import cycles by qualifying their package name with "_test". 3. Move the TestDirectoryServer into the tenantdirsvr package and rename the NewTestDirectoryServer method to just be New. 4. Move certificate files into new testdata directory. Release note: None
The tests were spewing out 150,000 warnings to the log when run because there is no denylist file present. This commit changes the proxy to not create the denylist service if no denylist file is provided. Release note: None
Our coding standard is to keep comments within an 80 char limit, assuming two characters per tab. This commit fixes up the code to conform to that. Relase note: None
andy-kimball
force-pushed
the
sqlproxy
branch
2 times, most recently
from
7d7b21f to
46cb2d4
Compare
1. updateMetricsAndSendErrToClient was called twice in proxyHandler. 2. Use GRPC NotFound error rather than error with text "not found". 3. Remove unnecessary code in ensureTenantEndpoint that was fetching endpoints before calling EnsureEndpoint. Release note: None
|
bors r+ |
|
Build succeeded: |
irfansharif
added a commit
to irfansharif/cockroach
that referenced
this pull request
Jul 6, 2021
Fixes cockroachdb#67010. Also clean up some rotted gomock generation in sqlproxyccl (mockgen usage was removed in cockroachdb#66369). Release note: None
irfansharif
added a commit
to irfansharif/cockroach
that referenced
this pull request
Jul 8, 2021
Fixes cockroachdb#67010. Also clean up some rotted gomock generation in sqlproxyccl (mockgen usage was removed in cockroachdb#66369). Release note: None
irfansharif
added a commit
to irfansharif/cockroach
that referenced
this pull request
Jul 19, 2021
Fixes cockroachdb#67010. Also clean up some rotted gomock generation in sqlproxyccl (mockgen usage was removed in cockroachdb#66369). Release note: None
craig bot
pushed a commit
that referenced
this pull request
Jul 19, 2021
67226: range{feed,client},roachpb: standardize mock generation through bazel r=irfansharif a=irfansharif
Fixes #67010. Also clean up some rotted gomock generation in sqlproxyccl
(mockgen usage was removed in #66369).
Release note: None
67478: backupccl: fix settings registry leak during restore r=pbardea a=pbardea
Previously, every time a restore data processor was created, a callback
was added to the settings registry to update the size of the pool. This
could potentially lead to a large growth in registered callbacks that
close over the processors created.
This commit replaces that mechanism with a background poller that polls
the cluster setting every 30 seconds to see if the worker pool needs
updating.
Release note (bug fix): Fix a minor resource leak that occurs when a
RESTORE is run.
Co-authored-by: irfan sharif <[email protected]>
Co-authored-by: Paul Bardea <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See commit comments for details.