bazel: exclude _bazel from consideration by gazelle
#65732
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tests. Since then, we've seen `gazelle` occasionally time out lint jobs in CI (see cockroachdb#65715). The error messages don't make a great deal of sense; a bunch of them look like this: gazelle: found packages exports (exports.go) and p (issue20046.go) in /go/src/github.com/cockroachdb/cockroach/_bazel/bin/pkg/testutils/lint/passes/forbiddenmethod/forbiddenmethod_test_/forbiddenmethod_test.runfiles/go_sdk/src/go/internal/gcimporter/testdata i.e., Gazelle is looking in `_bazel/bin`, finding `testdata` for the `go/internal/gcimporter` package in the `go_sdk`, and complaining about the results. So we add `_bazel` to the list of `exclude`s to prevent this. This is necessary according to bazel-contrib/bazel-gazelle#168. Release note: None
|
This change is |
|
Not completely sure this will completely repair the problem we're seeing in #65715, but it is a start. |
rail
approved these changes
May 26, 2021
complete! 1 of 0 LGTMs obtained
|
bors r=rail |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
tests. Since then, we've seen
gazelleoccasionally time out lint jobsin CI (see #65715). The error messages don't make a great deal of sense;
a bunch of them look like this:
i.e., Gazelle is looking in
_bazel/bin, findingtestdatafor thego/internal/gcimporterpackage in thego_sdk, and complaining aboutthe results. So we add
_bazelto the list ofexcludes to preventthis. This is necessary according to
bazel-contrib/bazel-gazelle#168.
Release note: None