Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sql: add CACHE clause to SHOW CREATE SEQUENCE when relevant #63548

Merged

Conversation

ajwerner
Copy link
Contributor

In 21.1 we added support for CACHE to sequences but we didn't add the logic
to render that clause.

Release note (bug fix): Render CACHE clause for sequences which use a cache.

@ajwerner ajwerner requested a review from rafiss April 13, 2021 13:26
@cockroach-teamcity
Copy link
Member

This change is Reviewable

@ajwerner
Copy link
Contributor Author

@rafiss feel free to redirect the review elsewhere. cc @ericharmeling

Copy link
Collaborator

@rafiss rafiss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ty! maybe worth testing in TestShowCreateSequence in show_test.go as well

In 21.1 we added support for `CACHE` to sequences but we didn't add the logic
to render that clause.

Release note (bug fix): Render `CACHE` clause for sequences which use a cache.
@ajwerner ajwerner force-pushed the ajwerner/show-cache-for-sequences branch from 4f0fbce to 5c4a1da Compare April 15, 2021 04:03
@ajwerner
Copy link
Contributor Author

ty! maybe worth testing in TestShowCreateSequence in show_test.go as well

Done.

@ajwerner
Copy link
Contributor Author

TFTR!

bors r=rafiss

@craig
Copy link
Contributor

craig bot commented Apr 16, 2021

Build succeeded:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants