Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sql: fix ADD COLUMN ... UNIQUE for PARTITION ALL BY tables #63123

Merged
merged 1 commit into from
Apr 7, 2021

Conversation

otan
Copy link
Contributor

@otan otan commented Apr 5, 2021

Refs: #63113

Release note (bug fix): Fixed a bug where doing ALTER TABLE ... ADD
COLUMN ... UNIQUE would error if the table had a PARTITION ALL BY /
REGIONAL BY ROW definition.

@otan otan requested review from ajstorm and a team April 5, 2021 23:48
@cockroach-teamcity
Copy link
Member

This change is Reviewable

Release note (bug fix): Fixed a bug where doing ALTER TABLE ... ADD
COLUMN ... UNIQUE would error if the table had a PARTITION ALL BY /
REGIONAL BY ROW definition.
@otan otan force-pushed the fix_unique_add_col branch 2 times, most recently from 70ae136 to 4f1698f Compare April 6, 2021 09:00
Copy link
Collaborator

@ajstorm ajstorm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 3 of 3 files at r1.
Reviewable status: :shipit: complete! 1 of 0 LGTMs obtained (waiting on @otan)

@otan
Copy link
Contributor Author

otan commented Apr 7, 2021

bors r=ajstorm

@craig
Copy link
Contributor

craig bot commented Apr 7, 2021

Build succeeded:

@craig craig bot merged commit 651184b into cockroachdb:master Apr 7, 2021
@rafiss rafiss added this to the 21.1 milestone Apr 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants