Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

log/logconfig: change exit-on-error to default to true for stderr #62763

Closed
wants to merge 1 commit into from
Closed

log/logconfig: change exit-on-error to default to true for stderr #62763

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions pkg/util/log/logconfig/config.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,6 @@ const DefaultFluentFormat = `json-fluent-compact`
// DefaultConfig returns a suitable default configuration when logging
// is meant to primarily go to files.
func DefaultConfig() (c Config) {
// TODO(knz): The default for 'stderr:exit-on-error' should probably be 'false'.
const defaultConfig = `
file-defaults:
filter: INFO
Expand All @@ -59,7 +58,7 @@ sinks:
format: ` + DefaultStderrFormat + `
redactable: true
channels: all
exit-on-error: true
exit-on-error: false
capture-stray-errors:
enable: true
`
Expand Down