release-21.1: sql: add tabledesc.NewUnsafeImmutable constructor #62616
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Recent benchmark results revealed a performance regression in TableReader caused by the recent introduction of the descriptor builder pattern which deep-copies descpb messages using protoutil.Clone. See issue cockroachdb#62212 and commit 15ee387. This commit adds an unsafe table descriptor constructor which is used with table descriptors in execinfrapb messages. This unsafe constructor does not perform a deep copy. In this particular context this isn't a problem, because the table descriptor proto only exists as a means to serialize table descriptors across nodes in a read-only fashion and is known to not be used in any other capacity. Release note: None
|
This change is |
15 tasks
ajwerner
reviewed
Mar 25, 2021
There was a problem hiding this comment.
Reviewed 12 of 13 files at r1.
Reviewable status:complete! 0 of 0 LGTMs obtained (waiting on @postamar)
ajwerner
approved these changes
Mar 25, 2021
There was a problem hiding this comment.
Reviewable status:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport 1/1 commits from #62388.
/cc @cockroachdb/release