release-21.1: backupccl: prevent restoring a newer backup #62398
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds a check during RESTORE that the backup(s) being restored were produced by a cluster with a cluster version no newer than the current version. The cluster version was not previously persisted in the backup so this new field is only set on new backups, but as this check is only in new versions, that is fine. Release note (ops change): RESTORE now refuses to restore BACKUPs made by newer versions.
|
This change is |
pbardea
approved these changes
Mar 22, 2021
ajwerner
approved these changes
Mar 23, 2021
There was a problem hiding this comment.
Note: this is checking the build version, not the cluster version
My reading of Active version does not align with this. Am I missing something?
Reviewed 2 of 5 files at r1.
Reviewable status:complete! 0 of 0 LGTMs obtained (waiting on @dt)
|
@ajwerner the msg was just out-of-date. in the pr discussion we changed our mind and used ClusterVersion instead. |
|
TFTR! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport 1/1 commits from #61737.
/cc @cockroachdb/release
This adds a check during RESTORE that the backup(s) being restored were produced by a version
no newer than the current version. The build info for the version that produced a
backup is persisted in the manifest and is used for this check.
Release note (ops change): RESTORE now refuses to restore BACKUPs made by newer versions.