release-21.1: sql: set default sample_rate to 0.1 #61815
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
|
I think we'll have to wait for the test fix (almost equal) and race fix (on the stopwatch) before merging this. |
yuzefovich
force-pushed
the
backport21.1-61760
branch
from
b927b14 to
b5e5f07
Compare
yuzefovich
force-pushed
the
backport21.1-61760
branch
from
b5e5f07 to
8c7a2a5
Compare
yuzefovich
added
do-not-merge
|
Ok, I think we can now proceed with this change once all the preliminary backports merge. I've pushed all of the cherry-picked commits here just to see a happy CI and will keep only the last 2 commits in this PR. |
|
I want to let this bake on master one more day. |
|
Sounds good |
Previously, when executing a PREPARE command, we would always reset the planner. This is not necessary when the origin of the command is SQL because in that case we properly reset the planner before starting the statement's execution. This change fixes a problem when PREPARE statements are chosen to be sampled for execution statistics (without the fix, we would encounter a nil pointer). Release note: None
Release note (sql change): Default value for `sql.txn_stats.sample_rate` cluster setting has been increased from 0 to 0.1. This means that from now on every statement has 10% probability of being sampled for the purposes of execution statistics. Note that no other criteria for sampling (like the query latencies) are currently being utilized to decide whether to sample a statement or not.
yuzefovich
force-pushed
the
backport21.1-61760
branch
from
8c7a2a5 to
8a0bba0
Compare
|
I don't think we've seen any fallout, so let's merge this. |
asubiotto
approved these changes
Mar 19, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport 2/2 commits from #61760.
/cc @cockroachdb/release
sql: do not reset planner if PREPARE is executed as a stmt
Previously, when executing a PREPARE command, we would always reset the
planner. This is not necessary when the origin of the command is SQL
because in that case we properly reset the planner before starting the
statement's execution. This change fixes a problem when PREPARE
statements are chosen to be sampled for execution statistics (without
the fix, we would encounter a nil pointer).
Release note: None
sql: set default sample_rate to 0.1
Fixes: #59379.
Release note (sql change): Default value for
sql.txn_stats.sample_ratecluster setting has been increased from 0 to 0.1. This means that from
now on every statement has 10% probability of being sampled for the
purposes of execution statistics. Note that no other criteria for
sampling (like the query latencies) are currently being utilized to
decide whether to sample a statement or not.