sql: clean up planNodeToRowSource #61412
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yuzefovich
requested review from
jordanlewis,
asubiotto,
a team and
dt
and removed request for
a team
|
Please ignore the first commit. |
|
This change is |
This commit removes some redundant things that were kept during ccc5a8a. Namely, `planNodeToRowSource` doesn't need to track whether it was started or not now that `startExec` is called in `Start`. This also allows us to remove the override of `InternalClose` method. Release justification: low-risk update to existing functionality. Release note: None
asubiotto
approved these changes
Mar 4, 2021
There was a problem hiding this comment.
Reviewed 1 of 1 files at r1.
Reviewable status:complete! 1 of 0 LGTMs obtained (waiting on @jordanlewis)
|
TFTR! bors r+ |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit removes some redundant things that were kept during
ccc5a8a. Namely,
planNodeToRowSourcedoesn't need to track whether it was started or not now that
startExecis called in
Start. This also allows us to remove the override ofInternalClosemethod.Release justification: low-risk update to existing functionality.
Release note: None