tracing: do not set tags when setting stats #61158
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is unnecessary given that we're setting the componentID below that includes the flowID. Release justification: low-risk update to new functionality. Release note: None
|
This change is |
yuzefovich
changed the title
We no longer need to set tags on the tracing span in order to propagate stats since we now propagate that info as a whole object (at the moment, twice - as a Structured payload and as DeprecatedStats protobuf; the latter will be removed after 21.1 branch is cut). Release justification: low-risk update to new functionality. Release note: None
yuzefovich
force-pushed
the
colflow-tag
branch
from
156078a to
d37ee52
Compare
RaduBerinde
approved these changes
Feb 26, 2021
There was a problem hiding this comment.
Reviewable status:
complete! 1 of 0 LGTMs obtained (waiting on @asubiotto)
|
TFTR! bors r+ |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
colflow: do not set redundant tag on the tracing span
This is unnecessary given that we're setting the componentID below that
includes the flowID.
Release justification: low-risk update to new functionality.
Release note: None
tracing: do not set tags when setting stats
We no longer need to set tags on the tracing span in order to propagate
stats since we now propagate that info as a whole object (at the moment,
twice - as a Structured payload and as DeprecatedStats protobuf; the
latter will be removed after 21.1 branch is cut).
Addresses: #59379.
Release justification: low-risk update to new functionality.
Release note: None