kv: complete client range info migrations #59395
Conversation
|
This change is |
nvanbenschoten
force-pushed
the
nvanbenschoten/clientRangeInfo
branch
from
e4d29e5 to
e5f2e43
Compare
There was a problem hiding this comment.
so
Reviewable status:
complete! 1 of 0 LGTMs obtained (waiting on @nvanbenschoten)
pkg/kv/kvclient/kvcoord/dist_sender.go, line 1967 at r1 (raw file):
log.VEventf(ctx, 2, "received updated range info: %s", br.RangeInfos) routing.EvictAndReplace(ctx, br.RangeInfos...) br.RangeInfos = nil
say again that this field doesn't make it past the DistSender
pkg/roachpb/api.proto, line 2029 at r1 (raw file):
// is left empty. Not set when Error is set. // // The server may also include additional RangeInfo objects if it suspects
say that this field is cleared by the DistSender, since it referes to multi-range considerations not exposed by the kv api
This commit completes a series of migrations relating to RangeInfo state and the client/server protocol for keeping the range descriptor cache up to date. The migrations were started in cockroachdb#51168, cockroachdb#51378, cockroachdb#51437. Concretely, this commit removes the following cluster versions: - `ClientRangeInfosOnBatchResponse` - `RangeStatsRespHasDesc` It addresses 6 TODOs. And it makes the following changes to the KV APi: - makes `Header.ClientRangeInfo` non-nullable. - deletes `Header.ReturnRangeInfo`. - deletes `ResponseHeader.DeprecatedRangeInfos`. - stops propagating `BatchResponse.RangeInfos` past `DistSender`. - makes RangeStatsResponse.RangeInfo non-nullable.
nvanbenschoten
force-pushed
the
nvanbenschoten/clientRangeInfo
branch
from
e5f2e43 to
e2c1477
Compare
There was a problem hiding this comment.
TFTR!
bors r+
Reviewable status:
pkg/kv/kvclient/kvcoord/dist_sender.go, line 1967 at r1 (raw file):
Previously, andreimatei (Andrei Matei) wrote…
say again that this field doesn't make it past the DistSender
Done.
pkg/roachpb/api.proto, line 2029 at r1 (raw file):
Previously, andreimatei (Andrei Matei) wrote…
say that this field is cleared by the DistSender, since it referes to multi-range considerations not exposed by the kv api
Done.
|
Build succeeded: |
This commit completes a series of migrations relating to RangeInfo state
and the client/server protocol for keeping the range descriptor cache up
to date. The migrations were started in #51168, #51378, #51437.
Concretely, this commit removes the following cluster versions:
ClientRangeInfosOnBatchResponseRangeStatsRespHasDescIt addresses 6 TODOs.
And it makes the following changes to the KV APi:
Header.ClientRangeInfonon-nullable.Header.ReturnRangeInfo.ResponseHeader.DeprecatedRangeInfos.BatchResponse.RangeInfospastDistSender.