-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
colexec: fix decimal/interval overload error propagation #58743
Conversation
Release note (bug fix): CockroachDB could previously return an internal error when evaluating a binary expression between a Decimal and an Interval that required a cast to a Float when the value is out of range, and now a more user-friendly error is returned instead.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
my remaining question is why the expression in the issue doesn't get folded?
Reviewable status:
complete! 1 of 0 LGTMs obtained (waiting on @asubiotto)
I'm guessing it might have to do with the fact whether the table we're reading from is empty or not, but I'm not sure. TFTR! bors r+ |
This PR was included in a batch that was canceled, it will be automatically retried |
Build failed (retrying...): |
Yeah, I think in the case when the table is empty, we have to not perform the constant folding:
|
Build succeeded: |
Fixes: #57773.
Release note (bug fix): CockroachDB could previously return an internal
error when evaluating a binary expression between a Decimal and an
Interval that required a cast to a Float when the value is out of range,
and now a more user-friendly error is returned instead.