server: remove support for binary protobuf payloads in the HTTP endpoints #58657
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
knz
force-pushed
the
20200108-server-proto
branch
from
f7435ff to
58f637a
Compare
…ints For a couple of releases we've only ever used JSON over the HTTP protocol. There is no need to support the binary protobuf encoding. This patch removes that option, which also reduces the opportunity for bugs in protobuf to be exploited. Release note: None
knz
force-pushed
the
20200108-server-proto
branch
from
58f637a to
c5eae6a
Compare
|
@aaron-crl suggests this should be backported. Will consider after the PR is reviewed. |
tbg
approved these changes
Jan 11, 2021
|
bors r=tbg |
This was referenced Jan 11, 2021
Merged
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For a couple of releases we've only ever used JSON over the HTTP
protocol. There is no need to support the binary protobuf encoding.
This patch removes that option, which also reduces the opportunity for
bugs in protobuf to be exploited.
Release note: None