Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sql: qualify table name for alter_table_owner event log #58504

Merged
merged 1 commit into from
Jan 12, 2021
Merged

sql: qualify table name for alter_table_owner event log #58504

merged 1 commit into from
Jan 12, 2021

Conversation

the-ericwang35
Copy link
Contributor

Fixes #57960.

Previously, event logs were not capturing the qualified table names
for ALTER TABLE OWNER commands.
This PR changes the event logs to use the qualified table name.
Tests were fixed to reflect these changes.

Release note (bug fix): qualify table name for alter_table_owner event log

Fixes #57960.

Previously, event logs were not capturing the qualified table names
for ALTER TABLE OWNER commands.
This PR changes the event logs to use the qualified table name.
Tests were fixed to reflect these changes.

Release note (bug fix): qualify table name for alter_table_owner event log
@cockroach-teamcity
Copy link
Member

This change is Reviewable

Copy link
Contributor

@ajwerner ajwerner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 2 of 2 files at r1.
Reviewable status: :shipit: complete! 1 of 0 LGTMs obtained

@the-ericwang35
Copy link
Contributor Author

bors r=ajwerner

@craig
Copy link
Contributor

craig bot commented Jan 12, 2021

Build failed:

@the-ericwang35
Copy link
Contributor Author

bors r=ajwerner

@craig
Copy link
Contributor

craig bot commented Jan 12, 2021

Build failed (retrying...):

@the-ericwang35
Copy link
Contributor Author

bors r=ajwerner

@craig
Copy link
Contributor

craig bot commented Jan 12, 2021

Already running a review

@craig
Copy link
Contributor

craig bot commented Jan 12, 2021

Build succeeded:

@craig craig bot merged commit 158601d into cockroachdb:master Jan 12, 2021
@the-ericwang35 the-ericwang35 deleted the ericwang/qualify_ownership_log branch January 12, 2021 20:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

sql: logged events for changes to table/view/seq ownership do not qualify the object name
3 participants