sqlsmith: enable partial index mutator #55761
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit re-enables the PartialIndexMutator for sqlsmith tests. This mutator was disabled in cockroachdb#55724 after bug fixes in cockroachdb#55702 revealed invalid schemas being created in sqlsmith. By reordering the mutators, randomly generated schemas are no longer invalid. Informs cockroachdb#55718 Release note: None
|
This change is |
yuzefovich
approved these changes
Oct 20, 2020
There was a problem hiding this comment.
Reviewed 1 of 1 files at r1.
Reviewable status:complete! 1 of 0 LGTMs obtained (waiting on @otan)
|
Stressing with the bad order caused a failure in ~5 test runs. I stressed this change for 600+ test runs without failure. |
|
bors r=yuzefovich |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit re-enables the PartialIndexMutator for sqlsmith tests. This
mutator was disabled in #55724 after bug fixes in #55702 revealed
invalid schemas being created in sqlsmith. By reordering the mutators,
randomly generated schemas are no longer invalid.
Informs #55718
Release note: None