sql: fix ALTER TABLE descriptorChanged bug #52819
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was some bad accounting in the ALTER TABLE command for whether the table descriptor had changed or not. This meant that for ALTER TABLE statements with multiple actions, we might incorrectly treat the whole statement as a no-op if the last action had no effect. Fixes cockroachdb#52816 Release note (bug fix): Fixed a bug for ALTER TABLE statements with multiple actions. In certain cases if the last action had no effect, the entire statement would be treated as a no-op.
|
This change is |
|
bors r+ |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was some bad accounting in the ALTER TABLE command for whether the
table descriptor had changed or not. This meant that for ALTER TABLE
statements with multiple actions, we might incorrectly treat the whole
statement as a no-op if the last action had no effect.
Fixes #52816
Release note (bug fix): Fixed a bug for ALTER TABLE statements with
multiple actions. In certain cases if the last action had no effect, the
entire statement would be treated as a no-op.