Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kv: consolidate RangeInfos in RPC responses #51168

Merged
merged 2 commits into from
Jul 10, 2020
Merged

kv: consolidate RangeInfos in RPC responses #51168

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
92743c0
kv: remove unused response field
andreimatei May 18, 2020
d86e265
kv: consolidate RangeInfos in RPC responses
andreimatei May 19, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
72 changes: 55 additions & 17 deletions c-deps/libroach/protos/roachpb/api.pb.cc
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

90 changes: 64 additions & 26 deletions c-deps/libroach/protos/roachpb/api.pb.h
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion docs/generated/settings/settings.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,6 +72,6 @@
<tr><td><code>trace.debug.enable</code></td><td>boolean</td><td><code>false</code></td><td>if set, traces for recent requests can be seen in the /debug page</td></tr>
<tr><td><code>trace.lightstep.token</code></td><td>string</td><td><code></code></td><td>if set, traces go to Lightstep using this token</td></tr>
<tr><td><code>trace.zipkin.collector</code></td><td>string</td><td><code></code></td><td>if set, traces go to the given Zipkin instance (example: '127.0.0.1:9411'); ignored if trace.lightstep.token is set</td></tr>
<tr><td><code>version</code></td><td>custom validation</td><td><code>20.1-9</code></td><td>set the active cluster version in the format '<major>.<minor>'</td></tr>
<tr><td><code>version</code></td><td>custom validation</td><td><code>20.1-10</code></td><td>set the active cluster version in the format '<major>.<minor>'</td></tr>
</tbody>
</table>
7 changes: 7 additions & 0 deletions pkg/clusterversion/cockroach_versions.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,6 +69,7 @@ const (
VersionAddScheduledJobsTable
VersionUserDefinedSchemas
VersionNoOriginFKIndexes
VersionClientRangeInfosOnBatchResponse

// Add new versions here (step one of two).
)
Expand Down Expand Up @@ -524,6 +525,12 @@ var versionsSingleton = keyedVersions([]keyedVersion{
Key: VersionNoOriginFKIndexes,
Version: roachpb.Version{Major: 20, Minor: 1, Unstable: 9},
},
{
// VersionClientRangeInfosOnBatchResponse moves the response RangeInfos from
// individual response headers to the batch header.
Key: VersionClientRangeInfosOnBatchResponse,
Version: roachpb.Version{Major: 20, Minor: 1, Unstable: 10},
},

// Add new versions here (step two of two).

Expand Down
Loading