Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kv/kvserver: fix TestSideloadingSideloadedStorage w/ RocksDB #50243

Merged
merged 1 commit into from
Jun 15, 2020
Merged

kv/kvserver: fix TestSideloadingSideloadedStorage w/ RocksDB #50243

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions pkg/kv/kvserver/replica_sideload_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -290,8 +290,7 @@ func testSideloadingSideloadedStorage(
if err == nil {
t.Fatalf("sideloaded directory should not have been removable due to extra file %s", nonRemovableFile)
}
expectedTruncateError := "while purging %q: remove %s: directory not empty"
if err.Error() != fmt.Sprintf(expectedTruncateError, ss.(*diskSideloadStorage).dir, ss.(*diskSideloadStorage).dir) {
if !strings.HasSuffix(strings.ToLower(err.Error()), "directory not empty") {
t.Fatalf("error truncating sideloaded storage: %+v", err)
}
// Now remove extra file and let truncation proceed to remove directory.
Expand Down