sql: stop observing the commit timestamp in TRUNCATE #44091
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
nvanbenschoten
approved these changes
Jan 16, 2020
ajwerner
force-pushed
the
ajwerner/stop-observing-commit-timestamp-in-truncate
branch
from
773190f to
ed46104
Compare
In cockroachdb#42650 I had intended to remove all places where the commit timestamp was observed in TRUNCATE. I missed this case. Modification times for the first write to table descriptors as of 19.2 should be the zero value (or the commit timestamp, so this isn't wrong). This observance of the commit timestamp prevents transactions which TRUNCATE tables from being pushed. Combined with cockroachdb#44090 we'll have removed all non-user observation of commit timestamps. Release note (bug fix): Long running transactions which attempt to TRUNCATE can now be pushed and will commit in cases where they previously could fail or retry forever.
ajwerner
force-pushed
the
ajwerner/stop-observing-commit-timestamp-in-truncate
branch
from
ed46104 to
a837af9
Compare
|
TFTR! bors r=nvanbenschoten |
Build succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #42650 I had intended to remove all places where the commit timestamp was
observed in TRUNCATE. I missed this case. Modification times for the first
write to table descriptors as of 19.2 should be the zero value (or the commit
timestamp, so this isn't wrong). This observance of the commit timestamp
prevents transactions which TRUNCATE tables from being pushed. Combined
with #44090 we'll have removed all non-user observation of commit timestamps.
Release note (bug fix): Long running transactions which attempt to TRUNCATE
can now be pushed and will commit in cases where they previously could fail
or retry forever.