colexec: support TIMESTAMPTZ type #43514
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
jordanlewis
approved these changes
Dec 26, 2019
There was a problem hiding this comment.
Reviewable status:
complete! 1 of 0 LGTMs obtained (waiting on @asubiotto)
This commit adds the support for TimestampTZ data type which is represented in the same way as Timestamp (as 'time.Time'). We already had everything in place, so only the type-conversion was needed. Release note (sql change): vectorized engine now supports TIMESTAMPTZ data type.
This commit adds previously supported INT2 and INT4 types to vecSeedTable as well as newly supported TIMESTAMPTZ. Release note: None
yuzefovich
force-pushed
the
vec-timestamptz
branch
from
9efc63d to
b3faa6b
Compare
|
TFTR! bors r+ |
craig bot
pushed a commit
that referenced
this pull request
Dec 31, 2019
43514: colexec: support TIMESTAMPTZ type r=yuzefovich a=yuzefovich **colexec: support TIMESTAMPTZ type** This commit adds the support for TimestampTZ data type which is represented in the same way as Timestamp (as 'time.Time'). We already had everything in place, so only the type-conversion was needed. Addresses: #42043. Release note (sql change): vectorized engine now supports TIMESTAMPTZ data type. **sqlsmith: add several types to vecSeedTable** This commit adds previously supported INT2 and INT4 types to vecSeedTable as well as newly supported TIMESTAMPTZ. Release note: None Co-authored-by: Yahor Yuzefovich <[email protected]>
Build succeededAnd happy new year from bors! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
colexec: support TIMESTAMPTZ type
This commit adds the support for TimestampTZ data type which is
represented in the same way as Timestamp (as 'time.Time'). We already
had everything in place, so only the type-conversion was needed.
Addresses: #42043.
Release note (sql change): vectorized engine now supports TIMESTAMPTZ
data type.
sqlsmith: add several types to vecSeedTable
This commit adds previously supported INT2 and INT4 types to
vecSeedTable as well as newly supported TIMESTAMPTZ.
Release note: None