release-19.1: rpc: notify callers to Connect when redial occurs before first heartbeat #42165
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
|
LGTM
…On Mon, Nov 4, 2019 at 6:11 PM cockroach-teamcity ***@***.***> wrote:
This change is [image: Reviewable]
<https://reviewable.io/reviews/cockroachdb/cockroach/42165>
—
You are receiving this because your review was requested.
Reply to this email directly, view it on GitHub
<#42165?email_source=notifications&email_token=AAC4C4JJ6O66PTOMZLMXM4DQSCT2VA5CNFSM4JI3JSZ2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEDBBHGI#issuecomment-549589913>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAC4C4JXF62JFDMDDXNUXYTQSCT2VANCNFSM4JI3JSZQ>
.
|
Before this patch callers would be left blocked on connect forever. Fixes cockroachdb#41521. Release note (bug fix): Fix bug whereby rapid network disconnections can lead to cluster unavailability because goroutines remain blocked waiting for a connection which will never be initialized to send its first heartbeat.
ajwerner
force-pushed
the
backport19.1-41533
branch
from
91040e1 to
508ffe7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport 1/1 commits from #41533.
/cc @cockroachdb/release
Before this patch callers would be left blocked on connect forever.
Fixes #41521.
Release note: None