sql: Add a SHOW RANGES FROM DATABASE command. #39194
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
solongordon
suggested changes
Aug 5, 2019
There was a problem hiding this comment.
A commit message would be welcome.
Reviewable status:
complete! 0 of 0 LGTMs obtained (waiting on @rohany and @solongordon)
pkg/sql/delegate/show_ranges.go, line 28 at r1 (raw file):
// SHOW RANGES FROM DATABASE db // // These statements show the ranges corresponding to the given table or index,
Out of date comment
pkg/sql/sem/tree/show.go, line 392 at r1 (raw file):
ctx.WriteString("TABLE ") } ctx.FormatNode(&node.TableOrIndex)
Looks like this is wrong in the database case.
solongordon
approved these changes
Aug 5, 2019
There was a problem hiding this comment.
Reviewable status:
|
bors r+ |
Merge conflict (retrying...) |
|
bors r- |
Canceled |
Fixes cockroachdb#36131. Adds a SHOW RANGES FROM DATABASE command, with similar output as SHOW RANGES FROM TABLE/INDEX. Release note (sql change): Add a SHOW RANGES FROM DATABASE command.
|
bors r+ |
craig bot
pushed a commit
that referenced
this pull request
Aug 5, 2019
39194: sql: Add a SHOW RANGES FROM DATABASE command. r=rohany a=rohany Fixes #36131. Release note (sql change): Add a SHOW RANGES FROM DATABASE command. Co-authored-by: Rohan Yadav <[email protected]>
Build succeeded |
This was referenced Aug 26, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #36131.
Release note (sql change): Add a SHOW RANGES FROM DATABASE command.