lint: make staticcheck happy on go 1.12 #36527
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
bdarnell
approved these changes
Apr 4, 2019
|
ugh, looks like the inline comment to disable the new rule doesn't play well on go 1.11 since there isn't a violation to disable there. |
the main issue is cgo generating 0==0, so we'll turn off that lint rule completely for now. Also, the regex copy rule is specific to go1.12 so we'll disable it on the log call while we still support go 1.11. Release note: none
|
switched to a glob-based ignore so it won't complain if it doesn't actually ignore anything. |
nvanbenschoten
approved these changes
Apr 4, 2019
|
bors r+ |
craig bot
pushed a commit
that referenced
this pull request
Apr 4, 2019
36527: lint: make staticcheck happy on go 1.12 r=dt a=dt the main issue is cgo generating 0==0, so we'll turn off that lint rule completely for now. Also, the regex copy rule is specific to go1.12 so we'll disable it on the log call while we still support go 1.11. Release note: none Co-authored-by: David Taylor <[email protected]>
Build succeeded |
dominikh
reviewed
Apr 9, 2019
| // TODO(dt): remove when https://github.com/dominikh/go-tools/issues/430 is resolved. | ||
| ignoreSA4000{}, | ||
| // We still support go 1.11 where regex.Copy avoids contention. | ||
| &lint.GlobIgnore{Pattern: "github.com/cockroachdb/cockroach/pkg/util/log/clog.go", Checks: []string{"SA1019"}}, |
There was a problem hiding this comment.
Once I fix dominikh/go-tools#437 you'll be able to use the -go 1.11 flag to not generate deprecation warnings for things that were deprecated in later versions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the main issue is cgo generating 0==0, so we'll turn off that lint rule completely for now.
Also, the regex copy rule is specific to go1.12 so we'll disable it on the log call while we still support go 1.11.
Release note: none