engine: iterate in-mem SSTs without copying #36394
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
danhhz
reviewed
Apr 1, 2019
There was a problem hiding this comment.
Reviewable status:
complete! 1 of 0 LGTMs obtained (waiting on @danhhz, @dt, @jordanlewis, and @lucy-zhang)
pkg/storage/engine/sst_iterator.go, line 76 at r1 (raw file):
} func (_ memFileInfo) IsDir() bool {
I usually see this as (memFileInfo)
dt
force-pushed
the
addsst-mem
branch
2 times, most recently
from
887003d to
c3e7eee
Compare
Release note (performance change): reduce memory usage during bulk ingestion of data (during IMPORT, RESTORE, and index creation).
|
bors r+ |
dt
commented
Apr 1, 2019
There was a problem hiding this comment.
Reviewable status:
pkg/storage/engine/sst_iterator.go, line 76 at r1 (raw file):
Previously, danhhz (Daniel Harrison) wrote…
I usually see this as
(memFileInfo)
Done
dt
commented
Apr 1, 2019
There was a problem hiding this comment.
TFTR!
Reviewable status:
craig bot
pushed a commit
that referenced
this pull request
Apr 1, 2019
36394: engine: iterate in-mem SSTs without copying r=dt a=dt Release note (performance change): reduce memory usage during bulk ingestion of data (during IMPORT, RESTORE, and index creation). Co-authored-by: David Taylor <[email protected]>
Build succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Release note (performance change): reduce memory usage during bulk ingestion of data (during IMPORT, RESTORE, and index creation).