sql: fix semantics of JSON ? operator on strings #35005
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
justinj
force-pushed
the
fix-qmark
branch
2 times, most recently
from
36fa050 to
2851a10
Compare
jordanlewis
approved these changes
Feb 19, 2019
There was a problem hiding this comment.
Reviewable status:
knz
approved these changes
Feb 21, 2019
Fixes cockroachdb#35001. Release note (sql change): The semantics of the JSON '?' operator when applied to JSON strings has been changed to match Postgres. Now, a JSON string '?'s a string when the two are equal.
|
Thanks for the reviews! bors r+ |
|
👎 Rejected by PR status |
|
tryin again bors r+ |
craig bot
pushed a commit
that referenced
this pull request
Feb 23, 2019
35005: sql: fix semantics of JSON ? operator on strings r=justinj a=justinj Fixes #35001. Release note (sql change): The semantics of the JSON '?' operator when applied to JSON strings has been changed to match Postgres. Now, a JSON string '?'s a string when the two are equal. Co-authored-by: Justin Jaffray <[email protected]>
Build succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #35001.
Release note (sql change): The semantics of the JSON '?' operator when
applied to JSON strings has been changed to match Postgres. Now, a JSON
string '?'s a string when the two are equal.