backport-2.1: storage: correctly handle empty forwarded proposals #31734
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The code assumed that an empty proposal would be a command ID with empty data, but it's also possible that the entire slice is empty (command IDs+data is our encoding; Raft itself emits an entry with completely blank data). Fixes cockroachdb#31050. Release note: None
nvanbenschoten
force-pushed
the
forward-npe
branch
from
a4f99f0 to
fb86e20
Compare
tbg
approved these changes
Oct 23, 2018
|
Yeah, exactly. As long as we don't find other issues with #31408. |
This was referenced Oct 23, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #31050.
Closes #31066.
The code assumed that an empty proposal would be a command ID with empty data, but it's also possible that the entire slice is empty (command IDs+data is our encoding; Raft itself emits an entry with completely blank data).
This is the backport of #31066, which no longer needs to be merged into master. The only changes in this PR are that I addressed my comments from #31066 (review).
Release note: None