release-2.1: storage: re-enqueue Raft groups on paginated application #31619
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
nvanbenschoten
force-pushed
the
backport2.1-31408-31568
branch
from
53d91f3 to
d4e6fb8
Compare
bdarnell
approved these changes
Oct 23, 2018
There was a problem hiding this comment.
I would also have been OK with merging this without a test and without the first commit (but it's fine as-is)
Reviewable status:
complete! 0 of 0 LGTMs obtained (and 1 stale)
This centralizes all Raft configuration and makes it easier to configure in tests. Release note: None
Fixes cockroachdb#31330. This change re-enqueues Raft groups for processing immediately if they still have more to do after a Raft ready iteration. This comes up in practice when a Range has sufficient load to force Raft application pagination. See cockroachdb#31330 for a discussion on the symptoms this can cause. Release note (bug fix): Fix bug where Raft followers could fall behind leaders will entry application, causing stalls during splits.
tbg
force-pushed
the
backport2.1-31408-31568
branch
from
d4e6fb8 to
e24dd67
Compare
|
@nvanbenschoten I'm getting this in for you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport:
Please see individual PRs for details.
The first commit is from #31408. I don't love that I needed to backport it, but I also can't easily test the rest of the change without it.
/cc @cockroachdb/release