Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ui: add cluster/per-node toggle to time series charts #30685

Closed
wants to merge 8 commits into from

Conversation

couchand
Copy link
Contributor

Adds a toggle to switch between cluster-wide aggregated data and per-node data for many of the charts on the time series dashboards.

Fixes: #14598
Fixes: #18452
Fixes: #20571

New:
new-per-node

Old:
old-no-per-node

Release note: None
Release note (admin ui change): Add an aggregation level selector to
the time series dashboards, allowing the user to drill down to per-
node data for many charts.
@couchand couchand requested a review from a team September 26, 2018 20:08
@cockroach-teamcity
Copy link
Member

This change is Reviewable

@Amruta-Ranade
Copy link
Contributor

Amruta-Ranade commented Sep 27, 2018

Yay for landing the PR 🎉

First impressions: It might be just me, but the Cluster/Node drop-down and Cluster-Per Node toggle seem incredibly confusing. I know they are supposed to serve two different functions. Is there a way we can make the nomenclature reflect the difference?

@vilterp
Copy link
Contributor

vilterp commented Sep 27, 2018

I like the simplicity of this approach, but I was surprised when I toggled to per-node mode and saw that multi-metric graphs didn't expand into num metrics graphs, each with one series per node, and just chose one of the metrics instead (e.g. sql.query.count instead of {selects, inserts, updates, deletes} and replicas instead of {replicas, quiesced}). Maybe it wouldn't be too much work to do the "multiple charts for different metrics in one card" design from the other PR? Let's discuss more…

@josueeee
Copy link

josueeee commented Oct 1, 2018

I agree with this observation. It is confusing and we should discuss how we can rearrange the order of the menu to make it easier to understand along with better nomenclature. There's also some design polish to be made on the labelling of the per-node charts.

First impressions: It might be just me, but the Cluster/Node drop-down and Cluster-Per Node toggle seem incredibly confusing. I know they are supposed to serve two different functions. Is there a way we can make the nomenclature reflect the difference?

@couchand couchand closed this Nov 15, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants