gossip: Don't include gossip connectivity in periodic status logs #30285
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As discussed on cockroachdb#30088. It can be absolutely massive on large clusters, and isn't needed because we still log the connectivity info whenever it changes. Release note: None
|
This change is |
petermattis
approved these changes
Sep 17, 2018
There was a problem hiding this comment.
Reviewable status:
complete! 0 of 0 LGTMs obtained (and 1 stale)
|
bors r+ |
craig bot
pushed a commit
that referenced
this pull request
Sep 17, 2018
30035: builder: upgrade to go1.11 r=bdarnell,raduberinde,nvanbenschoten a=benesch Go 1.11 brings us some nice performance improvements on single-node clusters. See #29827 for benchmark results. Fix #29827. Release note: None 30285: gossip: Don't include gossip connectivity in periodic status logs r=a-robinson a=a-robinson As discussed on #30088. It can be absolutely massive on large clusters, and isn't needed because we still log the connectivity info whenever it changes. Release note: None I still think that logging on every change in connectivity is going to be a mess in large clusters during rolling restarts even if gossip is otherwise perfectly stable, but this is useful regardless of whether we do anything about that. Co-authored-by: Nikhil Benesch <[email protected]> Co-authored-by: Alex Robinson <[email protected]>
Build succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed on #30088. It can be absolutely massive on large clusters,
and isn't needed because we still log the connectivity info whenever it
changes.
Release note: None
I still think that logging on every change in connectivity is going to be a mess in large clusters during rolling restarts even if gossip is otherwise perfectly stable, but this is useful regardless of whether we do anything about that.