backport-2.1: storage,kv: remove some allocations #29077
Conversation
Guard an expensive log.V in a log.ExpensiveLogEnabled. Pass roachpb.Lease by value in one situation in which allocating it is pointless. Release note: None
|
This change is |
|
bors r+ |
Build failed |
|
bors r+ |
Build failed |
|
bors r+ |
Build failed |
|
This flaky test is also seemingly flaky on release 2.1. let's try once more bors r+ |
|
@jordanlewis could you comment on why these fail before you retry? I know it's annoying and I wish we had tooling for it, but IMO it's still worth doing or flakiness will go up not down. |
|
Yeah, sorry. The flake is a test timeout. The test gets wedged with some locks waiting on each other. I couldn't reproduce locally until I moved the test timeout to 10s in stressrace, but then I could also reproduce on release-2.1. Mainly confused how TC hits this so frequently but stressrace doesn't turn it up without very low timeouts. |
Build failed |
|
That was a different failure: TestReopenConnection. What the heck? I can't believe that this would be caused by this patch. And yet, I don't see this flaking elsewhere . |
|
I've got something similar (different test though) going on over in #29033 (comment). Not sure what to make of it yet. |
|
One more try. I still can't see the connection and I can't reproduce with stress race. bors r+ |
|
I think the bors batch crashed? World's hardest PR to merge bors r+ |
There was a problem hiding this comment.
Reviewable status:
complete! 1 of 0 LGTMs obtained
29077: backport-2.1: storage,kv: remove some allocations r=jordanlewis a=jordanlewis Backport 1/1 commits from #29075. /cc @cockroachdb/release --- Guard an expensive log.V in a log.ExpensiveLogEnabled. Pass roachpb.Lease by value in one situation in which allocating it is pointless. cc @benesch This seems to improve read-only kv performance by almost 5%! Release note: None 29103: release-2.1: base: make TestValidateAddrs portable r=knz a=knz Backport 1/1 commits from #29101. /cc @cockroachdb/release --- On (at least) osx the port name resolution error is different. This patch modifies the test to catch that. Release note: None 29121: release-2.1: opt: fix LookupJoinDef interning, add tests r=RaduBerinde a=RaduBerinde Backport 1/1 commits from #29117. /cc @cockroachdb/release --- Fixing an omission I noticed in internLookupJoinDef and adding missing tests for interning defs. Release note: None Co-authored-by: Jordan Lewis <[email protected]> Co-authored-by: Raphael 'kena' Poss <[email protected]> Co-authored-by: Radu Berinde <[email protected]>
Build succeeded |
|
|
Backport 1/1 commits from #29075.
/cc @cockroachdb/release
Guard an expensive log.V in a log.ExpensiveLogEnabled.
Pass roachpb.Lease by value in one situation in which allocating it is
pointless.
cc @benesch
This seems to improve read-only kv performance by almost 5%!
Release note: None