ui: add hardware metrics to new "Hardware" dashboard #27626
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
This was referenced Jul 16, 2018
vilterp
force-pushed
the
hardware-dashboard
branch
3 times, most recently
from
073d8d7 to
c91abdb
Compare
couchand
reviewed
Jul 23, 2018
| sources={nodeSources} | ||
| > | ||
| {/* TODO(vilterp): multiply by 100 to get percent */} | ||
| <Axis units={AxisUnits.Count} label="CPU"> |
There was a problem hiding this comment.
Oh, hey, at one point I removed an AxisUnits.Percent cause it wasn't used anywhere... Here ya go: 70c4419
| @@ -48,7 +49,8 @@ const dashboards: {[key: string]: GraphDashboard} = { | |||
| "replication": { label: "Replication", component: replicationDashboard }, | |||
| "distributed": { label: "Distributed", component: distributedDashboard }, | |||
| "queues": { label: "Queues", component: queuesDashboard }, | |||
| "requests": { label: "Slow Requests", component: requestsDashboard}, | |||
| "requests": { label: "Slow Requests", component: requestsDashboard }, | |||
| "hardware": { label: "Hardware", component: hardwareDashboard }, | |||
There was a problem hiding this comment.
I would sort it much higher, maybe second after "overview"? @piyush-singh @josueeee @Amruta-Ranade thoughts?
|
LGTM |
vilterp
force-pushed
the
hardware-dashboard
branch
from
c91abdb to
6bc23a5
Compare
added 4 commits
July 23, 2018 12:12
This reverts commit 70c4419. Release note: none
Release note (admin ui change): add "Hardware" dashboard to time series page showing CPU, memory, and disk and network IO statistics.
Release note: None
Previously, it cut off right above the new "Hardware" option, making it look like it wasn't there. Release note: None
vilterp
force-pushed
the
hardware-dashboard
branch
from
6bc23a5 to
2f25296
Compare
|
bors r+ |
craig bot
pushed a commit
that referenced
this pull request
Jul 23, 2018
27626: ui: add hardware metrics to new "Hardware" dashboard r=vilterp a=vilterp First two commits are from #27137; that PR will go in first.  TODO - [ ] tooltips - [ ] format CPU percentage (currently 100% of one core = 1) Co-authored-by: Pete Vilter <[email protected]>
Build succeeded |
|
Awesome to see these new graphs! There does seem to be some overlap between this "Hardware" dashboard and the old "Runtime" and "Storage" dashboards. Is this part of a larger plan to re-organize all of them? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First two commits are from #27137; that PR will go in first.
TODO