cherrypick-2.0: ui: a variety of minor fixes #24116
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The explicit back links are hard to keep up, particularly since a given page may be linked to from multiple locations. Since the browser back button works just as well, this removes the back links from nodes & events pages. Fixes: cockroachdb#23682 Release note (admin ui change): Remove explicit back links on Events and Nodes pages.
This makes the top bar styles on the node list match those of the node map. Fixes: cockroachdb#23802 Release note: None
Fixes: cockroachdb#23889 Release note: None
Fixes: cockroachdb#23419 Release note: None
Fixes: cockroachdb#23903 Release note: None
This fixes a rare issue where a valid timestamp cannot be found for a particular hover point on the time series charts. For now it ignores a related set of problems where time series have different missing points. Fixes: cockroachdb#23011 Release note: None
|
This change is |
vilterp
approved these changes
Mar 21, 2018
bdarnell
approved these changes
Mar 21, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
result is undefinedon time series screen #23011)A cherry pick of #23904.
cc @cockroachdb/release @vilterp