cherry-pick 2.0: sql: introduce connExecutor, the query execution orchestrator #22812
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch removes the flavor of force_retry that explicitly takes in a transaction id. This function was used to test that SQL has protection for not retrying on a retriable error that was intended for a different txn. It has outlived its usefulness: lower layers now have protection against returning a retriable error for the wrong txn to SQL. I don't want to keep the SQL-level protection in the connExecutor code. Release note: None
|
This change is |
|
Please cherry-pick your last changes to #22277 here too. |
Release note: None The connExecutor is the top dog that interfaces with a pgwire connection (through the clientComm and CommandResult interfaces), consumes a stream of queries and produces a stream of results. It encapsulates the connection state machine for which it produces events. It interfaces with the two SQL execution engines for actually running queries. Its main responsibility is to dispatch statements based on the current state (in txn, not in txn, in aborted txn, etc) and to handle execution in all states but Open (in Open it talks to an execution engine). It also handles other commands than executiong queries: preparing, binding, etc and it maintains the session state associated with prepares statements.
andreimatei
force-pushed
the
cherry-pick-conn-ex
branch
from
30c02f5 to
418b7f1
Compare
|
There's been no changes to #22277 since creating this PR. Review status: 0 of 54 files reviewed at latest revision, all discussions resolved, all commit checks successful. Comments from Reviewable |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-pick #22780
Cherry-pick #22277
cc @cockroachdb/release