c-deps: Pull in fixes for rocksdb disk contention issues #20442
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook/rocksdb#3211 fixes the CMake build flags to enable the `sync_file_range` syscall which is required by the `bytes_per_sync` feature. facebook/rocksdb#3208 modernizes how background compactions/flushes are configured, which helped prevent stalls in some of my testing. cc cockroachdb#19699
|
This change is |
benesch
approved these changes
Dec 4, 2017
13 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
facebook/rocksdb#3211 fixes the CMake build
flags to enable the
sync_file_rangesyscall which is required by thebytes_per_syncfeature.facebook/rocksdb#3208 modernizes how background
compactions/flushes are configured, which helped prevent stalls in some
of my testing.
cc #19699