Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

server: open most HTTP endpoints later #19598

Merged
merged 1 commit into from
Oct 28, 2017
Merged

Conversation

tbg
Copy link
Member

@tbg tbg commented Oct 27, 2017

Extracted from #19591
which also adds a regression test. The tests in that PR pass, but
to make sure I verified manually using

while true; do curl -O /dev/null http://localhost:8080/_status/vars; done

and ./cockroach start --insecure in another window, ten times.

Fixes #19559.

@tbg tbg requested a review from a team October 27, 2017 18:25
@cockroach-teamcity
Copy link
Member

This change is Reviewable

Copy link
Contributor

@a-robinson a-robinson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, as in #19591 .

Although you referred to "fixing" #19493 again even though it's a merged PR. Is there an issue you meant to refer to instead?

Extracted from cockroachdb#19591
which also adds a regression test. The tests in that PR pass, but
to make sure I verified manually using

```
while true; do curl -O /dev/null http://localhost:8080/_status/vars; done
```

and `./cockroach start --insecure` in another window, ten times.

Fixes cockroachdb#19559.
@tbg
Copy link
Member Author

tbg commented Oct 27, 2017

Thanks! I meant #19559. Edited the commit and PR messages.

@tbg tbg merged commit 7d85274 into cockroachdb:master Oct 28, 2017
@tbg tbg deleted the late-http branch October 28, 2017 14:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants