sql: disambiguate ANY/ALL/SOME exprs in formatting #19569
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, ANY/ALL/SOME expressions would be formatted without parentheses around their antecedents. This could lead to invalid input. For example, the following query doesn't parse properly since the type annotation binds to the comparison expression, not the array: ``` SELECT 1 = ANY ARRAY[1]:::INT[] ``` This patch adds the disambiguating enclosing parenthesis.
|
This change is |
|
Split from #19424 |
|
Review status: 0 of 5 files reviewed at latest revision, all discussions resolved, all commit checks successful. Comments from Reviewable |
|
TFTR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, ANY/ALL/SOME expressions would be formatted without
parentheses around their antecedents. This could lead to invalid input.
For example, the following query doesn't parse properly since the type
annotation binds to the comparison expression, not the array:
This patch adds the disambiguating enclosing parenthesis.
Fixes the roundtrip problems mentioned in #19555.