Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

acceptance: de-flake test_missing_log_output #19402

Merged
merged 1 commit into from
Oct 20, 2017
Merged

acceptance: de-flake test_missing_log_output #19402

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 2 additions & 6 deletions pkg/cli/interactive_tests/test_missing_log_output.tcl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,7 +76,7 @@ start_test "Test that quit does not emit unwanted logging output"
# Unwanted: between the point the command starts until it
# either prints the final ok message or fails with some error
# (e.g. due to no definite answer from the server).
send "echo marker; $argv quit 2>&1 | grep '^\\(\[IWEF\]\[0-9\]\\)' \r"
send "echo marker; $argv quit 2>&1 | grep -vE '^\[IWEF\]\[0-9\]+ .\ vendor/google.golang.org/grpc/' | grep -vE '^\(ok|Error\)'\r"
set timeout 20
eexpect "marker\r\n:/# "
set timeout 5
Expand All @@ -87,11 +87,7 @@ start_test "Test that quit does not show INFO by defaults with --logtostderr"
# that the default logging level is WARNING, so that no INFO messages
# are printed between the marker and the (first line) error message
# from quit. Quit will error out because the server is already stopped.
#
# Since quit is likely to actually emit warnings, but we are just
# interested in the absence of INFO messages, remove the warnings from
# the output.
send "echo marker; $argv quit --logtostderr 2>&1 | grep -v '^W'\r"
send "echo marker; $argv quit --logtostderr 2>&1 | grep -vE '^\[WEF\]\[0-9\]+ .\* vendor/google.golang.org/grpc/'\r"
eexpect "marker\r\nError"
eexpect ":/# "
end_test
Expand Down