build: move {metacheck,unconvert} into style_test #19395
Conversation
|
This change is |
| @@ -76,7 +76,7 @@ start_test "Test that quit does not emit unwanted logging output" | |||
| # Unwanted: between the point the command starts until it | |||
| # either prints the final ok message or fails with some error | |||
| # (e.g. due to no definite answer from the server). | |||
| send "echo marker; $argv quit 2>&1 | grep '^\\(\[IWEF\]\[0-9\]\\)' \r" | |||
| send "echo marker; $argv quit 2>&1 | grep -vE '^\[IWEF\]\[0-9\]+ grpc: '\r" | |||
There was a problem hiding this comment.
Not good enough, I think! We need to match
W171020 12:24:14.884065 21 vendor/google.golang.org/grpc/clientconn.go:1034 grpc: addrConn.resetTransport failed to create client transport:
So I'm missing a .* somewhere.
There was a problem hiding this comment.
Good point! Fixed in #19402.
|
In my testing, this reduces |
|
Ah, looks like @a-robinson kindly rebuilt this. |
|
This looks pretty good to me and the speedup is nice. It could use a few more inline comments (i.e. what's the megachecker struct, etc) but Reviewed 1 of 1 files at r1, 28 of 28 files at r6, 3 of 3 files at r7, 1 of 1 files at r8, 26 of 26 files at r9, 1 of 1 files at r10. Comments from Reviewable |
all files reviewed at latest revision, all discussions resolved, all commit checks successful.This also checks tests, which were previously not covered.
|
Happy to add whatever comments you'd like to see; added one for the struct, but lmk if you want to see others - I'll do that in a follow-up. Gonna need a rebuild to get past these new flakes though! |
|
Thank you, kind stranger! |
Avoids shelling out; runs everything in the test process and avoids
unconvert's extra parsing of the AST.