do not merge: WIP commits for debugging a production issue #16564
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I suspect that contention on this semaphore is causing failed heartbeats in a production cluster.
|
This change is |
Note that because all of these keys are behind the GCThreshold, it doesn't matter that we're not deleting them in FIFO order.
bdarnell
changed the title
bdarnell
added a commit
to bdarnell/cockroach
that referenced
this pull request
Jul 6, 2017
There's no reason to block our own liveness updates when incrementing another node's epoch; doing so could cause cascading failures when the liveness span gets slow. This was originally suspected as the cause of cockroachdb#16565 (and was proposed in cockroachdb#16564). That issue turned out to have other causes, but this change seems like a good idea anyway.
bdarnell
added a commit
to bdarnell/cockroach
that referenced
this pull request
Jul 6, 2017
There's no reason to block our own liveness updates when incrementing another node's epoch; doing so could cause cascading failures when the liveness span gets slow. This was originally suspected as the cause of cockroachdb#16565 (and was proposed in cockroachdb#16564). That issue turned out to have other causes, but this change seems like a good idea anyway.
bdarnell
added a commit
to bdarnell/cockroach
that referenced
this pull request
Jul 10, 2017
There's no reason to block our own liveness updates when incrementing another node's epoch; doing so could cause cascading failures when the liveness span gets slow. This was originally suspected as the cause of cockroachdb#16565 (and was proposed in cockroachdb#16564). That issue turned out to have other causes, but this change seems like a good idea anyway.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I suspect that contention on this semaphore is causing failed
heartbeats in a production cluster.
This PR is based on release-1.0 so it can be tried immediately; if the experiment is successful I'll polish it up before merging and make a version for
master.