-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
sql: allow schema changes on tables in state: TableDescriptor_ADD #15929
Conversation
Review status: 0 of 3 files reviewed at latest revision, all discussions resolved, all commit checks successful. Comments from Reviewable |
I thought about what would be safest change to make here and felt that passing in a boolean Review status: 0 of 9 files reviewed at latest revision, all discussions resolved, some commit checks pending. Comments from Reviewable |
Let me add a few more tests to this PR before merging it. Review status: 0 of 9 files reviewed at latest revision, all discussions resolved, some commit checks pending. Comments from Reviewable |
A new table descriptor is placed in the non-public TableDescriptor_ADD state when it refers to another table through an FK or interleaved reference, and can only be made public once the other tables back reference is visible across the cluster. This change allows schema change operations on such non-public tables, while preserving the non-public behavior for table leases. fixes cockroachdb#13505
I've added a few more tests to this PR. Thanks Review status: 0 of 9 files reviewed at latest revision, all discussions resolved, some commit checks pending. Comments from Reviewable |
Review status: 0 of 9 files reviewed at latest revision, all discussions resolved, all commit checks successful. Comments from Reviewable |
A new table descriptor is placed in the non-public TableDescriptor_ADD state
when it refers to another table through an FK or interleaved reference,
and can only be made public once the other tables back reference is
visible across the cluster.
This change allows schema change operations on such non-public tables,
while preserving the non-public behavior for table leases.
fixes #13505