distsqlrun: fix double output close in joinReader #14236
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Will try to add a test so hold off on this a bit. |
|
Added a test. This change fixes #14360. |
|
@asubiotto did you want to close this? |
|
No, it was a mistake. I'm waiting on @andreimatei to reopen by re-pushing his commit. |
|
The new commit is not being picked up. Created a new PR with the test in #14420 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We had a bug when emitHelper() returned false - because the consumer was
closed. A ret val of false means that emitHelper() also closed the
output. But the joinReader was trying to close it again, resulting in a
panic.
Discovered while trying to run the TPCH query from #13989 while killing
a node.
This change is