release-24.1: sql/types: preserve tuple labels in (*T).WithoutTypeModifiers
#142137
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mgartner
requested review from
a team and
yuzefovich
and removed request for
a team
![blathers[crl]](https://avatars.githubusercontent.com/in/59700?s=40&u=373d9101a12edc3847d2fb6ae78e3adcfb4ca41e&v=4){kind=avatar}
|
Thanks for opening a backport. Please check the backport criteria before merging:
If your backport adds new functionality, please ensure that the following additional criteria are satisfied:
Also, please add a brief release justification to the body of your PR to justify this |
blathers-crl
bot
added
the
backport
|
This change is |
yuzefovich
approved these changes
Feb 28, 2025
There was a problem hiding this comment.
Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status:complete! 0 of 0 LGTMs obtained (waiting on @michae2)
-- commits line 13 at r1:
nit: mention 24.1.7 version.
Previously, the `WithoutTypeModifiers` method incorrectly removed tuple labels from the returned type. This has been fixed. Fixes cockroachdb#136167 Release note (bug fix): A bug has been fixed that disregarded tuple labels in some cases. This could cause unexpected behavior, such as when converting a tuple to JSON with `to_jsonb`. See cockroachdb#136167 for more details. The incorrect removal of tuple labels bug was introduced in v22.1.0, and changes in v24.1.7 made unexpected behavior due to the bug more likely.
mgartner
force-pushed
the
backport24.1-138791
branch
from
2888626 to
de57c8e
Compare
mgartner
commented
Feb 28, 2025
There was a problem hiding this comment.
Reviewable status:
Previously, yuzefovich (Yahor Yuzefovich) wrote…
nit: mention 24.1.7 version.
Done
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport 1/1 commits from #138791.
/cc @cockroachdb/release
Previously, the
WithoutTypeModifiersmethod incorrectly removed tuplelabels from the returned type. This has been fixed.
Fixes #136167
Release note (bug fix): A bug has been fixed that disregarded tuple
labels in some cases. This could cause unexpected behavior, such as when
converting a tuple to JSON with
to_jsonb. See #136167 for moredetails. The incorrect removal of tuple labels bug was introduced in
v22.1.0, and changes in v24.1.7 made unexpected behavior due to the bug
more likely.
Release justification: Minor bug fix.