kvserver/rangefeed: add kv.rangefeed.lifetime_nanos #142134
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch introduces two new metrics -
kv.rangefeed.{buffered,unbuffered}_registrations. They track the number of
corresponding active buffered and unbuffered rangefeeds subscribed on
replicas.
Part of: cockroachdb#129816
Release note: none
This patch introduces a new metric, kv.rangefeed.output_loop_nanos_unbuffered_reg, which tracks the duration of the per-range, per-registration runOutputLoop goroutine. This goroutine is expected to be short-lived for unbuffered registrations, while it remains long-lived for buffered registrations. Note that this metric is only non-zero for unbuffered registrations. Part of: cockroachdb#129816 Release note: none
|
This change is |
wenyihu6
force-pushed
the
unbufregmetrics2
branch
2 times, most recently
from
0d3d900 to
1a37137
Compare
This patch refactors rangefeed metrics in node.Metrics into a dedicated StreamManagerMetrics struct. This improves modularity and aligns with future additions like BufferedSenderMetrics. Epic: none Release note: none
This patch adds a new metric, rangefeed.buffered_sender.queue_size, to track the number of entries pending in the buffered sender queue waiting to be sent to rpc stream. Part of: cockroachdb#129816 Release note: none
wenyihu6
force-pushed
the
unbufregmetrics2
branch
from
1a37137 to
e67e424
Compare
This patch adds a new metric, kv.rangefeed.lifetime_nanos, to track the duration of rangefeed lifetime between its successful instantiation and disconnection. Note that the counter starts when the registration is instantiated, though there may be a short delay before it registers with the processor and begins receiving events. We ignore this gap as it is expected to be short. Part of: cockroachdb#129816 Release note: none
wenyihu6
force-pushed
the
unbufregmetrics2
branch
from
e67e424 to
0492a5d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch adds a new metric, kv.rangefeed.lifetime_nanos, to track the duration
of rangefeed lifetime between its successful instantiation and disconnection.
Note that the counter starts when the registration is instantiated, though there
may be a short delay before it registers with the processor and begins receiving
events. We ignore this gap as it is expected to be short.
Part of: #129816
Release note: none