(draft)logstore: log latency if raftentry cache miss when calling loadTerm #141159
+67
−28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![blathers[crl]](https://avatars.githubusercontent.com/in/59700?s=40&u=373d9101a12edc3847d2fb6ae78e3adcfb4ca41e&v=4){kind=avatar}
|
It looks like your PR touches production code but doesn't add or edit any test code. Did you consider adding tests to your PR? 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf. |
|
This change is |
hakuuww
force-pushed
the
logLoadTermLatencyIfCacheMiss
branch
from
2e1d341 to
b43fd00
Compare
pav-kv
reviewed
Feb 12, 2025
hakuuww
changed the title
hakuuww
force-pushed
the
logLoadTermLatencyIfCacheMiss
branch
5 times, most recently
from
e51358f to
65f7539
Compare
This is a draft commit that adds a metric to record the latency for loading term if there is a cache miss. Also adds separate metrics for raftRntry cache accesses from loadTerm. Running roachtests against this build will help us with understanding the access patterns of raftEntry Cache, and understand how much performance improvement we may get when we introduce a term cache. This commit is only for reference purpose, shouldn't be merged. References: cockroachdb#136296 Epic: None Release note: None
hakuuww
force-pushed
the
logLoadTermLatencyIfCacheMiss
branch
from
65f7539 to
8e8c121
Compare
hakuuww
added a commit
to hakuuww/cockroach
that referenced
this pull request
Feb 20, 2025
Integrate with metrics from another branch cockroachdb#141159 References: cockroachdb#136296 Epic: None Release note: None
hakuuww
added a commit
to hakuuww/cockroach
that referenced
this pull request
Feb 20, 2025
Integrate with metrics from another branch cockroachdb#141159 References: cockroachdb#136296 Epic: None Release note: None
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(draft change) This is a draft commit that adds a metric to record the latency for loading term if there is a cache miss.
Also adds separate metrics for raftRntry cache accesses from loadTerm.
Running roachtests against this build will help us with understanding the access patterns of raftEntry Cache, and understand how much performance improvement we may get when we introduce a term cache.
This commit is only for reference purpose, do not merge.
References: #136296
Epic: None
Release note: None