-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
logictest: raise TxnLivenessThreshold for multitenant configs #140607
logictest: raise TxnLivenessThreshold for multitenant configs #140607
Conversation
Logic tests are flaky due to overload when running in multitenant mode. This patch increases the threshold for transaction heartbeat timeouts, which will make it less likely for foreground operations to be aborted by background jobs like the span config reconciler or the job registry loop to reclaim jobs from dead sessions. Release note: None
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status:complete! 1 of 0 LGTMs obtained (waiting on @fqazi)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!
Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status:complete! 2 of 0 LGTMs obtained (waiting on @rafiss)
TFTRs bors r+ |
bors p=99 |
Based on the specified backports for this PR, I applied new labels to the following linked issue(s). Please adjust the labels as needed to match the branches actually affected by the issue(s), including adding any known older branches. Issue #140572: branch-release-24.1, branch-release-24.2, branch-release-24.3, branch-release-25.1. Issue #140605: branch-release-24.1, branch-release-24.2, branch-release-24.3. Issue #140546: branch-release-24.1, branch-release-24.2, branch-release-24.3, branch-release-25.1. Issue #140577: branch-release-24.1, branch-release-24.2, branch-release-24.3, branch-release-25.1. Issue #140062: branch-release-24.1, branch-release-24.2, branch-release-24.3. Issue #140574: branch-release-24.1, branch-release-24.2, branch-release-24.3, branch-release-25.1. Issue #140063: branch-release-24.1, branch-release-24.2, branch-release-24.3. Issue #140542: branch-release-24.1, branch-release-24.2, branch-release-24.3, branch-release-25.1. Issue #140545: branch-release-24.1, branch-release-24.2, branch-release-24.3, branch-release-25.1. Issue #139776: branch-release-24.1, branch-release-24.3, branch-release-25.1. Issue #140544: branch-release-24.1, branch-release-24.2, branch-release-24.3, branch-release-25.1. Issue #140552: branch-release-24.1, branch-release-24.2, branch-release-24.3. Issue #139761: branch-release-24.1, branch-release-24.2, branch-release-25.1. Issue #140011: branch-release-24.1, branch-release-24.2, branch-release-24.3, branch-release-25.1. Issue #139990: branch-release-24.1, branch-release-24.2, branch-release-24.3, branch-release-25.1. Issue #140565: branch-release-24.1, branch-release-24.2, branch-release-24.3. Issue #140578: branch-release-24.1, branch-release-24.2, branch-release-24.3, branch-release-25.1. Issue #140614: branch-release-24.1, branch-release-24.2, branch-release-24.3. Issue #140560: branch-release-24.1, branch-release-24.2, branch-release-24.3, branch-release-25.1. Issue #140541: branch-release-24.1, branch-release-24.2, branch-release-24.3, branch-release-25.1. Issue #140597: branch-release-24.1, branch-release-24.2, branch-release-24.3, branch-release-25.1. Issue #140494: branch-release-24.1, branch-release-24.2, branch-release-24.3, branch-release-25.1. Issue #140553: branch-release-24.1, branch-release-24.2, branch-release-24.3, branch-release-25.1. Issue #140161: branch-release-24.1, branch-release-24.2, branch-release-24.3. Issue #140608: branch-release-24.1, branch-release-24.2, branch-release-24.3, branch-release-25.1. Issue #139890: branch-release-24.1, branch-release-24.3, branch-release-25.1. Issue #140543: branch-release-24.1, branch-release-24.2, branch-release-24.3, branch-release-25.1. Issue #140072: branch-release-24.1, branch-release-24.2, branch-release-24.3. 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf. |
blathers backport 24.3 25.1 |
Logic tests are flaky due to overload when running in multitenant mode. This patch increases the threshold for transaction heartbeat timeouts, which will make it less likely for foreground operations to be aborted by background jobs like the span config reconciler or the job registry loop to reclaim jobs from dead sessions.
fixes #140597
fixes #140494
fixes #140578
fixes #140577
fixes #140572
fixes #140574
fixes #139890
fixes #140565
fixes #140542
fixes #140543
fixes #140545
fixes #140544
fixes #140546
fixes #140560
fixes #140552
fixes #140541
fixes #140553
fixes #139990
fixes #139776
fixes #140072
fixes #139761
fixes #140161
fixes #140063
fixes #140062
fixes #140011
fixes #140605
fixes #140614
fixes #140608
Release note: None