sql: update grant_table logictests to not cause massive diffs #140278
Conversation
![blathers[crl]](https://avatars.githubusercontent.com/in/59700?s=40&u=373d9101a12edc3847d2fb6ae78e3adcfb4ca41e&v=4){kind=avatar}
|
Your pull request contains more than 1000 changes. It is strongly encouraged to split big PRs into smaller chunks. 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf. |
|
This change is |
normanchenn
force-pushed
the
norman/order-grant_table
branch
from
f1c32cc to
f12d1ca
Compare
There was a problem hiding this comment.
Thanks for cleaning this up! I have just one nit.
Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status:complete! 0 of 0 LGTMs obtained (waiting on @normanchenn)
pkg/sql/logictest/testdata/logic_test/grant_table line 24 at r1 (raw file):
# to filter the built-in internal vtables down to just one so that we are not # enumerating all builtins and being overly broad and brittle. query TTTTTTB colnames,rowsort
nit: let's remove rowsort directives where we now have proper ORDER BY clauses.
Previously, there was no ordering in the grant_table logictest queries, causing any rewrite of these logic tests (i.e. the result of adding types) to result in large diffs. Now, these queries are ordered so the diffs will make more sense. Epic: None Release note: None
normanchenn
force-pushed
the
norman/order-grant_table
branch
from
f12d1ca to
a6b6d45
Compare
There was a problem hiding this comment.
bors r+
Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status:
|
Build failed (retrying...): |
Previously, there was no ordering in the grant_table logictest queries, causing any rewrite of these logic tests (i.e. the result of adding types) to result in large diffs. Now, these queries are ordered so the diffs will make more sense.
Epic: None
Release note: None