release-25.1: sql/rowenc: reduce index key prefix calls #140275
Merged
+122
−36
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport 2/2 commits from #139256.
/cc @cockroachdb/release
sql/rowenc: reduce index key prefix calls
This patch removes redundant calls to
MakeIndexKeyPrefix
duringthe construction of
IndexEntry
s by saving each first-time call in amap that we can later lookup. Previously, we would make this call
for each row; however, as the prefix (table id + index id) for a
particular index remains the same, we do not need to do any
recomputation.
Epic: CRDB-42901
Fixes: #137798
Release note: None
sql/rowexec: run BenchmarkIndexBackfill on-disk
Epic: none
Release note: None
Release justification: low-risk backfill alloc improvement