Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

release-24.2.9-rc: sql: do not collect histograms for non-indexed JSON columns #140267

Merged
merged 1 commit into from
Jan 31, 2025
Merged

release-24.2.9-rc: sql: do not collect histograms for non-indexed JSON columns #140267

merged 1 commit into from
Jan 31, 2025

Conversation

blathers-crl[bot]
Copy link

@blathers-crl blathers-crl bot commented Jan 31, 2025 •
edited by mgartner
Loading

Backport 1/1 commits from #139766.

/cc @cockroachdb/release

Informs #139381

Release note (sql change): Since v23.2 table statistics histograms have
been collected for non-indexed JSON columns. Histograms are no longer
collected for these columns if sql.stats.non_indexed_json_histograms.enabled
is set to false. This reduces memory usage during table
statistics collection, for both automatic and manual collection via
ANALYZE and CREATE STATISTICS.

Release justification: New cluster setting disabled by default.

@mgartner
sql: do not collect histograms for non-indexed JSON columns
ba4d61d 
Informs #139381

Release note (sql change): Since v23.2 table statistics histograms have
been collected for non-indexed JSON columns. Histograms are no longer
collected for these columns if `sql.stats.non_indexed_json_histograms.enabled`
is set to `false`. This reduces memory usage during table
statistics collection, for both automatic and manual collection via
`ANALYZE` and `CREATE STATISTICS`.
@blathers-crl blathers-crl bot requested a review from a team as a code owner January 31, 2025 20:50
@blathers-crl blathers-crl bot force-pushed the blathers/backport-release-24.2.9-rc-140141 branch from 0c81d39 to ba4d61d Compare January 31, 2025 20:50
@blathers-crl blathers-crl bot added blathers-backport This is a backport that Blathers created automatically. O-robot Originated from a bot. labels Jan 31, 2025
@blathers-crl blathers[crl]
Copy link
Author

blathers-crl bot commented Jan 31, 2025

Thanks for opening a backport.

Please check the backport criteria before merging:

  • Backports should only be created for serious
    issues     or test-only changes.
  • Backports should not break backwards-compatibility.
  • Backports should change as little code as possible.
  • Backports should not change on-disk formats or node communication protocols.
  • Backports should not add new functionality (except as defined
    here).
  • Backports must not add, edit, or otherwise modify cluster versions; or add version gates.
  • All backports must be reviewed by the owning areas TL. For more information as to how that review should be conducted, please consult the backport
    policy    .
If your backport adds new functionality, please ensure that the following additional criteria are satisfied:
  • There is a high priority need for the functionality that cannot wait until the next release and is difficult to address in another way.
  • The new functionality is additive-only and only runs for clusters which have specifically “opted in” to it (e.g. by a cluster setting).
  • New code is protected by a conditional check that is trivial to verify and ensures that it only runs for opt-in clusters. State changes must be further protected such that nodes running old binaries will not be negatively impacted by the new state (with a mixed version test added).
  • The PM and TL on the team that owns the changed code have signed off that the change obeys the above rules.
  • Your backport must be accompanied by a post to the appropriate Slack
    channel (#db-backports-point-releases or #db-backports-XX-X-release) for awareness and discussion.

Also, please add a brief release justification to the body of your PR to justify this
backport.

@blathers-crl blathers-crl bot added the backport Label PR's that are backports to older release branches label Jan 31, 2025
@cockroach-teamcity
Copy link
Member

This change is Reviewable

@mgartner mgartner changed the title release-24.2.9-rc: release-24.2: sql: do not collect histograms for non-indexed JSON columns release-24.2: sql: do not collect histograms for non-indexed JSON columns Jan 31, 2025
@mgartner mgartner changed the title release-24.2: sql: do not collect histograms for non-indexed JSON columns release-24.2.9-rc: sql: do not collect histograms for non-indexed JSON columns Jan 31, 2025
yuzefovich
yuzefovich approved these changes Jan 31, 2025
View reviewed changes
Copy link
Member

@yuzefovich yuzefovich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 4 of 4 files at r1, all commit messages.
Reviewable status: :shipit: complete! 0 of 0 LGTMs obtained (waiting on @mgartner)

@mgartner mgartner merged commit f82f66a into release-24.2.9-rc Jan 31, 2025
19 of 20 checks passed
@mgartner mgartner deleted the blathers/backport-release-24.2.9-rc-140141 branch January 31, 2025 21:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yuzefovich yuzefovich yuzefovich approved these changes

Assignees

@mgartner mgartner

Labels
backport Label PR's that are backports to older release branches blathers-backport This is a backport that Blathers created automatically. O-robot Originated from a bot.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cockroach-teamcity @yuzefovich @mgartner